Compatibility with jQuery 1.9 and changes to dropdown position #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 27, 2013 18:51
$.browser has been deprecated for a while, and dropped from jQuery 1.9. The code was using it to deal with browser differences about text selection handling; references to $.browser have been removed, and text selection handling has been enhanced to handle all browsers (by using code from the jQuery.selection plugin). More testing and tweaking may be required.
The tag list dropdown used to always appear at the bottom of the text area; this is undesirable if the text area gets big and you are editing a tag at the top of the text. These changes move the dropdown close to the tag being edited by the user. This code is a bit kludgy and may require further tweaking, but it is a good start.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two commits make the plugin compatible with jQuery 1.9 by removing the reference to $.browser, and move the tag list dropdown close to the tag being edited by the user.
I'm sure more tweaking is necessary but I think it can be a start. Please let me know if any changes are needed.